Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Send telemetry for manual refresh #1253

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CsCherrYY
Copy link
Collaborator

@CsCherrYY CsCherrYY commented Jul 18, 2022

now we just dismiss telemetry for command gradle.refresh.

this.registerCommandWithoutInstrument(
COMMAND_REFRESH,
new RefreshCommand(
this.gradleTaskProvider,
this.gradleBuildContentProvider,
this.gradleTasksTreeDataProvider,
this.recentTasksTreeDataProvider
)
);

since changing the build file will trigger a refresh command, but we should still collect manual refresh commands via view title and command palette.

@CsCherrYY CsCherrYY added the eng engineering work label Jul 18, 2022
@CsCherrYY CsCherrYY added this to the July 2022 milestone Jul 18, 2022
@CsCherrYY CsCherrYY force-pushed the cs-refresh-telemetry branch from 0600b7b to a473ddf Compare July 22, 2022 06:27
@CsCherrYY CsCherrYY removed this from the July 2022 milestone Jul 25, 2022
@CsCherrYY CsCherrYY force-pushed the cs-refresh-telemetry branch from a473ddf to dcdc8ae Compare April 17, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng engineering work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant